Skip to content

Fix embedding dialog opening for navigation entry#3072

Merged
arsen-afaunov merged 1 commit intomainfrom
CHARTS-12010-fix-embedding-dialog-opening-for-navigation-entry
Oct 28, 2025
Merged

Fix embedding dialog opening for navigation entry#3072
arsen-afaunov merged 1 commit intomainfrom
CHARTS-12010-fix-embedding-dialog-opening-for-navigation-entry

Conversation

@arsen-afaunov
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

📦 Statoscope quick diff with main-branch:

⏱ Build time: 262 ms (0.49%)

⚖️ Initial size: 0.03 kb (0%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

E2E Tests No Auth

Playwright test results

passed  183 passed
flaky  5 flaky
skipped  2 skipped

Details

stats  190 tests across 105 suites
duration  3 minutes, 12 seconds
commit  0c305ac

Flaky tests

opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/wizard/fields/parameters.test.ts › Wizard › Fields › Renaming should not affect the operation of the parameter
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/pivot-table/sorting.test.ts › Wizard › Pivot table › Sorting a row by a field with a parameter
opensource › opensource-suites/wizard/visualizations/scatter/coloring.test.ts › Wizard › Scatter chart › Point color set by the fake title of the field @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-10-28 11:44:26 MSK

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

E2E Tests

Playwright test results

passed  183 passed
flaky  5 flaky
skipped  2 skipped

Details

stats  190 tests across 105 suites
duration  2 minutes, 47 seconds
commit  0c305ac

Flaky tests

opensource › opensource-suites/dash/revisions/revisionsListWithCreationDashboards.test.ts › Dashboards - Versioning › Creating a dashboard, editing, saving as a draft, making the draft version relevant
opensource › opensource-suites/wizard/filters/filters-with-dialog-color.test.ts › Wizard filters › Two or more values of the Date field from the dashboard filter section should use IN operation by default
opensource › opensource-suites/wizard/visualizations/flat-table/preview.test.ts › Wizard › Flat table › Event "chart-preview.done" is triggered for table with no data
opensource › opensource-suites/wizard/visualizations/flat-table/sorting.test.ts › Wizard › Flat table › Tree column sorting
opensource › opensource-suites/wizard/visualizations/pivot-table/totals.test.ts › Wizard › Pivot table › Subtotals for NULL values

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled


🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-10-28 11:44:04 MSK

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

E2E Tests Farm

Playwright test results

passed  418 passed
flaky  7 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  5 minutes, 5 seconds
commit  0c305ac

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on connection
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Ql - Export menu item is disabled if export is forbidden on connection
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets


👉 Link with detailed report: report

Last updated: 2025-10-28 11:49:30 MSK

korvin89
korvin89 previously approved these changes Oct 27, 2025
@arsen-afaunov arsen-afaunov force-pushed the CHARTS-12010-fix-embedding-dialog-opening-for-navigation-entry branch from a269771 to 5d04b51 Compare October 28, 2025 08:17
@arsen-afaunov arsen-afaunov force-pushed the CHARTS-12010-fix-embedding-dialog-opening-for-navigation-entry branch from 5d04b51 to 0c305ac Compare October 28, 2025 08:39
@arsen-afaunov arsen-afaunov merged commit eae90a7 into main Oct 28, 2025
13 checks passed
@arsen-afaunov arsen-afaunov deleted the CHARTS-12010-fix-embedding-dialog-opening-for-navigation-entry branch October 28, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants